Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Éric Vyncke's Transport Comment 4 #4527

Closed
LPardue opened this issue Jan 6, 2021 · 7 comments
Closed

Éric Vyncke's Transport Comment 4 #4527

LPardue opened this issue Jan 6, 2021 · 7 comments
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list. iesg An issue raised during IESG review.

Comments

@LPardue
Copy link
Member

LPardue commented Jan 6, 2021

Éric Vyncke said:

-- Section 4.2 and others --
The specification is rather vague about the behavior (no default timer, no
default "window", nothing said about increasing the credit, ...) and leaves a
lot to implantations. Is it an issue or is it described in QUIC-RECOVERY ?

@LPardue LPardue added -transport iesg An issue raised during IESG review. labels Jan 6, 2021
@LPardue LPardue added this to the transport-iesg milestone Jan 6, 2021
@martinthomson
Copy link
Member

Yes, the recovery draft includes all the necessary timers (aside from the idle timeout, which I think is adequately covered). However, if you are talking about flow control specifically, then that does not necessarily need timers. Other commenters have bemoaned the lack of guidance regarding flow control and it has improved, but the prevailing view of the working group is that it is only a problem if you try to optimize. So we have what is written, which says that if you want tight flow control limits (in the order of BDP), then you risk performance problems if you don't provide timely updates.

@LPardue LPardue changed the title Érik Vyncke's Transport Comment 4 Éric Vyncke's Transport Comment 4 Jan 6, 2021
@larseggert larseggert added this to Triage in Late Stage Processing via automation Jan 11, 2021
@MikeBishop
Copy link
Contributor

The willingness to allow more flow control credit is (almost?) always triggered by an event, such as the application reading from the stream; or a stream being reset and the stack deciding to discard the buffered data. As such, flow control can be implemented purely on an event-based basis. Now, this isn't optimal for performance -- you might not want to generate flow control updates every time one of these events happens, but rather coalesce them -- but that's an optimization that implementations can decide whether and how to pursue.

@martinthomson
Copy link
Member

Many stacks also increase their buffer allocations in response to increases in perceived BDP.

@martinthomson
Copy link
Member

As this is an issue the working group has consensus on, I don't think we should change anything. However, it is more than simply editorial, so I can't close the issue. I propose that we do though.

@larseggert
Copy link
Member

Labelling this as design, but am noting your suggestion to close with no action.

@larseggert larseggert added the design An issue that affects the design of the protocol; resolution requires consensus. label Jan 12, 2021
@project-bot project-bot bot moved this from Triage to Design Issues in Late Stage Processing Jan 12, 2021
@DavidSchinazi
Copy link
Contributor

I support closing with no action.

@LPardue LPardue added the call-issued An issue that the Chairs have issued a Consensus call for. label Jan 18, 2021
@LPardue LPardue moved this from Design Issues to Consensus Call issued in Late Stage Processing Jan 18, 2021
@LPardue
Copy link
Member Author

LPardue commented Feb 3, 2021

Closing this now that the IESG have approved the document(s).

@LPardue LPardue closed this as completed Feb 3, 2021
Late Stage Processing automation moved this from Consensus Call issued to Issue Handled Feb 3, 2021
@LPardue LPardue added has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list. and removed call-issued An issue that the Chairs have issued a Consensus call for. labels Feb 21, 2021
@project-bot project-bot bot moved this from Issue Handled to Consensus Declared in Late Stage Processing Feb 21, 2021
@LPardue LPardue moved this from Consensus Declared to Issue Handled in Late Stage Processing Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list. iesg An issue raised during IESG review.
Projects
Late Stage Processing
  
Issue Handled
Development

No branches or pull requests

5 participants