Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[Coding style change] Rename variables so that they start with a lowe…
…rcase letter

This patch is mechanically generated by clang-llvm-rename tool that I wrote
using Clang Refactoring Engine just for creating this patch. You can see the
source code of the tool at https://reviews.llvm.org/D64123. There's no manual
post-processing; you can generate the same patch by re-running the tool against
lld's code base.

Here is the main discussion thread to change the LLVM coding style:
https://lists.llvm.org/pipermail/llvm-dev/2019-February/130083.html
In the discussion thread, I proposed we use lld as a testbed for variable
naming scheme change, and this patch does that.

I chose to rename variables so that they are in camelCase, just because that
is a minimal change to make variables to start with a lowercase letter.

Note to downstream patch maintainers: if you are maintaining a downstream lld
repo, just rebasing ahead of this commit would cause massive merge conflicts
because this patch essentially changes every line in the lld subdirectory. But
there's a remedy.

clang-llvm-rename tool is a batch tool, so you can rename variables in your
downstream repo with the tool. Given that, here is how to rebase your repo to
a commit after the mass renaming:

1. rebase to the commit just before the mass variable renaming,
2. apply the tool to your downstream repo to mass-rename variables locally, and
3. rebase again to the head.

Most changes made by the tool should be identical for a downstream repo and
for the head, so at the step 3, almost all changes should be merged and
disappear. I'd expect that there would be some lines that you need to merge by
hand, but that shouldn't be too many.

Differential Revision: https://reviews.llvm.org/D64121

llvm-svn: 365595
  • Loading branch information
rui314 committed Jul 10, 2019
1 parent 21b28fb commit 3837f42
Show file tree
Hide file tree
Showing 56 changed files with 12,292 additions and 12,292 deletions.
460 changes: 230 additions & 230 deletions lld/ELF/AArch64ErrataFix.cpp

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions lld/ELF/AArch64ErrataFix.h
Expand Up @@ -29,19 +29,19 @@ class AArch64Err843419Patcher {

private:
std::vector<Patch843419Section *>
patchInputSectionDescription(InputSectionDescription &ISD);
patchInputSectionDescription(InputSectionDescription &isd);

void insertPatches(InputSectionDescription &ISD,
std::vector<Patch843419Section *> &Patches);
void insertPatches(InputSectionDescription &isd,
std::vector<Patch843419Section *> &patches);

void init();

// A cache of the mapping symbols defined by the InputSecion sorted in order
// of ascending value with redundant symbols removed. These describe
// the ranges of code and data in an executable InputSection.
std::map<InputSection *, std::vector<const Defined *>> SectionMap;
std::map<InputSection *, std::vector<const Defined *>> sectionMap;

bool Initialized = false;
bool initialized = false;
};

} // namespace elf
Expand Down

0 comments on commit 3837f42

Please sign in to comment.